[Webkit-unassigned] [Bug 74169] Upstream 3 files into WebCore/platform/blackberry

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74169


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #118553|review?                     |review-
               Flag|                            |




--- Comment #8 from Rob Buis <rwlbuis at gmail.com>  2011-12-09 07:02:28 PST ---
(From update of attachment 118553)
View in context: https://bugs.webkit.org/attachment.cgi?id=118553&action=review

Mostly just some nits left.

> Source/WebCore/platform/blackberry/GeolocationServiceBlackBerry.cpp:106
> +                                                          true, // providesAltititude

providesAltititude?

> Source/WebCore/platform/blackberry/GeolocationServiceBlackBerry.cpp:112
> +                                                          0.0, // heading

0.0 -> 0

> Source/WebCore/platform/blackberry/GeolocationServiceBlackBerry.cpp:114
> +                                                          0.0); // speed

0.0 -> 0

> Source/WebCore/platform/blackberry/PageClientBlackBerry.h:45
> +    virtual void setPreventsScreenDimming(bool preventDimming) = 0;

preventDimming is obvious, can be removed.

> Source/WebCore/platform/blackberry/PageClientBlackBerry.h:46
> +    virtual void showVirtualKeyboard(bool showKeyboard) = 0;

showKeyboard is obvious, can be removed.

> Source/WebCore/platform/blackberry/PageClientBlackBerry.h:61
> +    virtual int showAlertDialog(BlackBerry::WebKit::WebPageClient::AlertType atype) = 0;

Remove atype

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.