[Webkit-unassigned] [Bug 74169] Upstream 3 files into WebCore/platform/blackberry

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74169





--- Comment #2 from Leo Yang <leo.yang at torchmobile.com.cn>  2011-12-09 00:33:24 PST ---
(From update of attachment 118540)
View in context: https://bugs.webkit.org/attachment.cgi?id=118540&action=review

Informal review. I only looked at I commented part and feel that you shouldn't mix style fix with you newly upstreamed files.

> Source/WebCore/ChangeLog:35
> +        * platform/blackberry/DragDataBlackBerry.cpp: Small style fix.
> +        (WebCore::DragData::containsURL):
> +        (WebCore::DragData::asFilenames):
> +        (WebCore::DragData::asURL):
> +        (WebCore::DragData::asFragment):
> +        * platform/blackberry/GeolocationServiceBlackBerry.cpp: Added.
> +        (WebCore::GeolocationServiceBlackBerry::create):
> +        (WebCore::GeolocationServiceBlackBerry::GeolocationServiceBlackBerry):
> +        (WebCore::GeolocationServiceBlackBerry::~GeolocationServiceBlackBerry):
> +        (WebCore::GeolocationServiceBlackBerry::startUpdating):
> +        (WebCore::GeolocationServiceBlackBerry::stopUpdating):
> +        (WebCore::GeolocationServiceBlackBerry::suspend):
> +        (WebCore::GeolocationServiceBlackBerry::resume):
> +        (WebCore::GeolocationServiceBlackBerry::lastPosition):
> +        (WebCore::GeolocationServiceBlackBerry::lastError):
> +        (WebCore::GeolocationServiceBlackBerry::onLocationUpdate):
> +        (WebCore::GeolocationServiceBlackBerry::onLocationError):
> +        (WebCore::GeolocationServiceBlackBerry::onPermission):
> +        (WebCore::GeolocationServiceBlackBerry::deferNotifications):
> +        (WebCore::GeolocationServiceBlackBerry::resumeNotifications):
> +        * platform/blackberry/GeolocationServiceBlackBerry.h: Added.
> +        (WebCore::GeolocationServiceBlackBerry::tracker):
> +        (WebCore::GeolocationServiceBlackBerry::hasDeferredNotifications):

Could you remove the information for each function since they are newly added?

> Source/WebCore/platform/blackberry/DragDataBlackBerry.cpp:71
>      return false;
>  }
>  
> -bool DragData::containsURL(Frame*, FilenameConversionPolicy filenamePolicy) const
> +bool DragData::containsURL(Frame*, FilenameConversionPolicy) const
>  {
>      notImplemented();
>      return false;
>  }
>  
> -void DragData::asFilenames(WTF::Vector<String, 0u>& result) const
> +void DragData::asFilenames(Vector<String>&) const
>  {
> -    // FIXME: remove explicit 0 size in result template once this is implemented
>      notImplemented();
>  }
>  

I would use a separate patch to do this.

> Source/WebCore/platform/blackberry/DragDataBlackBerry.cpp:91
> -String DragData::asURL(Frame*, FilenameConversionPolicy filenamePolicy, String* title) const
> +String DragData::asURL(Frame*, FilenameConversionPolicy, String*) const
>  {
>      notImplemented();
>      return String();
>  }
>  
> -WTF::PassRefPtr<DocumentFragment> DragData::asFragment(Frame*, PassRefPtr<Range> context,
> -                                            bool allowPlainText, bool& chosePlainText) const
> +PassRefPtr<DocumentFragment> DragData::asFragment(Frame*, PassRefPtr<Range>, bool, bool&) const
>  {

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.