[Webkit-unassigned] [Bug 73798] Upstream 6 files into WebCore/platform/blackberry
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 8 19:41:39 PST 2011
https://bugs.webkit.org/show_bug.cgi?id=73798
Rob Buis <rwlbuis at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #118511|review? |review-
Flag| |
--- Comment #13 from Rob Buis <rwlbuis at gmail.com> 2011-12-08 19:41:39 PST ---
(From update of attachment 118511)
View in context: https://bugs.webkit.org/attachment.cgi?id=118511&action=review
Some nits left. Once you have fixed, I am fine with the patch, so you can ask Leo to do the final r+ and cq.
> Source/WebCore/platform/blackberry/FileSystemBlackBerry.cpp:55
> + fileName = filePath + cpath.length();
How about:
char *fileName = filePath + cpath.length();
> Source/WebCore/platform/blackberry/FileSystemBlackBerry.cpp:61
> + fileNameSpace = sizeof(filePath) - (fileName - filePath) - 1;
Why not move it down to:
size_t fileNameSpace = sizeof(filePath) - (fileName - filePath) - 1;
> Source/WebCore/platform/blackberry/FileSystemBlackBerry.cpp:64
> + dir = opendir(cpath.data());
I would suggest : DIR* dir = opendir(path.data())
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list