[Webkit-unassigned] [Bug 74123] Move MediaDocument styles into CSS. Set black background for chromium.

Thu Dec 8 14:32:25 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=74123

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #118461|review?                     |review-
               Flag|                            |

--- Comment #6 from Darin Adler <darin at apple.com>  2011-12-08 14:32:25 PST ---
(From update of attachment 118461)
View in context: https://bugs.webkit.org/attachment.cgi?id=118461&action=review

>> Source/WebCore/html/MediaDocument.cpp:97
>> +    document()->recalcStyle(Node::Force);
> 
> So, as I was saying earlier, this should not be necessary.  I don't have a build in front of me, but perhaps you could take a peek and see if the style is _ever_ resolved on this document. And if it is, when. It seems weird that we have to kludge this like so.

Yes, that is absolutely unnecessary and if adding it has any benefit then there is a bug elsewhere.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.