[Webkit-unassigned] [Bug 74054] fast path to accelerate processing in AudioBus::processWithGainFromMonoStereo

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74054





--- Comment #2 from Raymond Toy <rtoy at chromium.org>  2011-12-08 14:06:21 PST ---
(From update of attachment 118326)
View in context: https://bugs.webkit.org/attachment.cgi?id=118326&action=review

Just a few minor questions;  the code changes look good.

> Source/WebCore/ChangeLog:3
> +        fast path to accelerate processing in AudioBus::processWithGainFromMonoStereo

Any idea on how much faster this runs with these changes?

> Source/WebCore/platform/audio/AudioBus.cpp:250
> +    bool needDezipper = fabs(totalDesiredGain-gain) > 0.001f;

How did you come up with 0.001?  If you just picked this "at random", please add a comment saying something like .001 seems small enough, but may need tweaking.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.