[Webkit-unassigned] [Bug 73668] Upstream BlackBerry API backing store files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73668


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #118047|review?                     |review-
               Flag|                            |




--- Comment #8 from Daniel Bates <dbates at webkit.org>  2011-12-08 13:32:58 PST ---
(From update of attachment 118047)
View in context: https://bugs.webkit.org/attachment.cgi?id=118047&action=review

> Source/WebKit/blackberry/Api/BackingStore.cpp:2437
> +#if OS(QNX)

Remove this if-define as it's unnecessary.

> Source/WebKit/blackberry/Api/BackingStore.cpp:2438
> +    // Store temps.

Remove this comment as it's inane.

> Source/WebKit/blackberry/Api/BackingStore.h:23
> +

Remove this empty line as it doesn't improve the readability of this file.

> Source/WebKit/blackberry/Api/BackingStore.h:25
> +#include <BlackBerryPlatformGraphics.h>
> +#include <BlackBerryPlatformPrimitives.h>

As far as I can tell we neither of these includes are necessary. Instead, we should just forward declare BlackBerry::Platform::IntRect.

> Source/WebKit/blackberry/Api/BackingStore_p.h:27
> +

Remove this empty line as it doesn't improve the readability of this file.

> Source/WebKit/blackberry/Api/BackingStore_p.h:354
> +}

Please add an inline comment on this line: // namespace WebKit

> Source/WebKit/blackberry/Api/BackingStore_p.h:355
> +}

Please add an inline comment on this line: // namespace BlackBerry

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.