[Webkit-unassigned] [Bug 74086] [chromium] Layer contents scale change should trigger invalidation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74086





--- Comment #4 from Adrienne Walker <enne at google.com>  2011-12-08 12:02:39 PST ---
(From update of attachment 118384)
View in context: https://bugs.webkit.org/attachment.cgi?id=118384&action=review

>>> Source/WebCore/platform/graphics/chromium/LayerChromium.cpp:428
>>> +    if (!needsContentsScale() || m_contentsScale == contentsScale)
>> 
>> I don't understand how this interacts with the needsContentsScale() check.  Only ContentLayerChromium handles contents scale at this point.  Do we want to set the contents scale for any layer, even if it doesn't handle it?
>> 
>> What layer type are you trying to solve this for?
> 
> The contents scale should only be set for layers for which needsContentScale() is true. The check that I've added is intended to avoid unnecessary invalidation in the case that the contents scale did not actually change from its current value. I haven't checked whether that actually happens; this is just a precaution.
> 
> I'm seeing the problem of missed invalidations on non-root ContentLayerChromium instances. The root layer is properly invalidated through WebViewImpl::invalidateRootLayerRect() when the page scale changes.

Thanks for the explanation; this makes a lot more sense to me with that context.  :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.