[Webkit-unassigned] [Bug 74049] Enable animations of CSS images using -webkit-cross-fade

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74049


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #118315|review?                     |review+
               Flag|                            |




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com>  2011-12-08 11:12:59 PST ---
(From update of attachment 118315)
View in context: https://bugs.webkit.org/attachment.cgi?id=118315&action=review

r=me but some transition tests wouldn't hurt.

> LayoutTests/animations/cross-fade-background-image.html:37
> +    @-webkit-keyframes "anim" {
> +        from { background-image: url(resources/blue-100.png); }
> +        to   { background-image: url(resources/green-100.png); }
> +    }
> +    @-webkit-keyframes "animShorthand" {
> +        from { background: url(resources/blue-100.png); }
> +        to   { background: url(resources/green-100.png); }

Animation names are IDENT, not STRING, so should not be quoted.

> LayoutTests/animations/resources/animation-test-helpers.js:54
> +	var matches = s.match("-webkit-cross-fade\\((.*)\\s*,\\s*(.*)\\s*,\\s*(.*)\\)");

Is the double escaping necessary?

> Source/WebCore/css/CSSCrossfadeValue.cpp:112
> +    if (fromImageSize.width() == toImageSize.width() && fromImageSize.height() == toImageSize.height())

Doesn't IntSize have an operator== ?

> Source/WebCore/page/animation/AnimationBase.cpp:239
> +    if (progress == 1.)

1. -> 1 or 1.0

> Source/WebCore/page/animation/AnimationBase.cpp:251
> +    RefPtr<StyleGeneratedImage> generatedImage = StyleGeneratedImage::create(crossfadeValue.get());

Could just return StyleGeneratedImage::create(crossfadeValue.get());

> Source/WebCore/page/animation/AnimationBase.cpp:274
> +    // FIXME: Support transitioning between NinePieceImages that differ by more than image content.

Please file a bug for this.

> Source/WebCore/page/animation/AnimationBase.cpp:286
> +    return newNinePieceImage;

return NinePieceImage(....) ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.