[Webkit-unassigned] [Bug 74095] Cache visited link hash

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74095


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #118398|                            |commit-queue-
               Flag|                            |




--- Comment #4 from Andreas Kling <kling at webkit.org>  2011-12-08 09:11:47 PST ---
(From update of attachment 118398)
View in context: https://bugs.webkit.org/attachment.cgi?id=118398&action=review

> Source/WebCore/ChangeLog:12
> +        On my machine this speeds up style matching on full HTML spec by ~100ms or ~1% of the total
> +        CPU usage. It makes link elements 8 bytes larger, a relatively minor increase to their overall size.

This sounds like a reasonable trade-off to me, though we should either finish the 64-bit LinkHash project, or go back to 32-bit.
Adding 4 bytes of always-zero data to HTMLAnchorElement is sad. :(

> Source/WebCore/html/HTMLAnchorElement.h:144
> +        m_cachedVisitedLinkHash = WebCore::visitedLinkHash(document()->baseURL(), fastGetAttribute(HTMLNames::hrefAttr));

You need to use getAttribute() for hrefAttr, as it's an SVG animatable attribute.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.