[Webkit-unassigned] [Bug 74074] [Qt] Visualize mock points in the Qt MiniBrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74074





--- Comment #7 from Tor Arne Vestbø <vestbo at webkit.org>  2011-12-08 07:19:16 PST ---
(From update of attachment 118383)
View in context: https://bugs.webkit.org/attachment.cgi?id=118383&action=review

> Tools/MiniBrowser/qt/BrowserWindow.cpp:107
> +        foreach (QQuickItem* item, rootObject()->childItems()) {
> +            QVariant itemId = item->property("id");
> +
> +            if (itemId.toString() == mockTouchPointIdentifier) {
> +                mockTouchPointItem = item;
> +                break;
> +            }
> +        }

Set the objectName instead of the id, and use rootObject()->findChild<QQuickItem*>(mockTouchPointIdentifier);

> Tools/MiniBrowser/qt/BrowserWindow.cpp:118
> +        mockTouchPointItem->setProperty("pressed", QVariant(pressed));

replace the pressed variable with touchPoint.state == Qt::TouchPointReleased

> Tools/MiniBrowser/qt/MiniBrowserApplication.cpp:166
> +    BrowserWindow* browserWindow = dynamic_cast<BrowserWindow*>(targetWindow);
> +
> +    if (browserWindow)
> +        browserWindow->updateVisualMockTouchPoints(m_touchPoints.values());
> +

if (BrowserWindow* browserWindow = qobject_cast<BrowserWindow*>(targetWindow))
    browserWindow->updateVisualMockTouchPoints(m_touchPoints.values());

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.