[Webkit-unassigned] [Bug 73534] upstream BlackBerry porting of MIMETypeRegistry/KeyboardEvent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73534


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #118348|review?                     |review-
               Flag|                            |




--- Comment #10 from Rob Buis <rwlbuis at gmail.com>  2011-12-08 07:15:28 PST ---
(From update of attachment 118348)
View in context: https://bugs.webkit.org/attachment.cgi?id=118348&action=review

Almost done, but since this needs cq+ the nit needs to be fixed first.

> Source/WebCore/platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:482
> +void PlatformKeyboardEvent::getCurrentModifierState(bool& shiftKey, bool& ctrlKey, bool& altKey, bool& metaKey)

The parameter names can be best removed or marked as unused.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.