[Webkit-unassigned] [Bug 74080] Upsteam the Qt changes to the EditorState

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74080


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #118373|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #5 from Simon Hausmann <hausmann at webkit.org>  2011-12-08 06:24:51 PST ---
(From update of attachment 118373)
View in context: https://bugs.webkit.org/attachment.cgi?id=118373&action=review

r=me with one change

> Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp:193
> +    EditorState state = m_page->editorState();
>  
> -        ExceptionCode ec = 0;
> -        RefPtr<Range> tempRange = range->cloneRange(ec);
> -        tempRange->setStart(tempRange->startContainer(ec), tempRange->startOffset(ec) + location, ec);
> -        IntRect caretRect = frame->view()->contentsToWindow(frame->editor()->firstRectForRange(tempRange.get()));
> -        IntRect nodeRect = frame->view()->contentsToWindow(scope->getRect());
> -
> -        m_page->send(Messages::WebPageProxy::FocusEditableArea(caretRect, nodeRect));
> -    }
> +#if PLATFORM(QT)
> +    if (Element* scope = frame->selection()->rootEditableElement())
> +        m_page->send(Messages::WebPageProxy::FocusEditableArea(state.microFocus, scope->getRect()));
>  #endif
>  
>      m_page->send(Messages::WebPageProxy::EditorStateChanged(m_page->editorState()));

The last call there should use the newly introduced state variable instead of requesting editorState() again.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.