[Webkit-unassigned] [Bug 74083] New: Define DEBUG_GL_COMMANDS only in debug builds.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74083

           Summary: Define DEBUG_GL_COMMANDS only in debug builds.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: nayankk at motorola.com


This bug will fix following issues with Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp
a). Define DEBUG_GL_COMMANDS only for debug builds. Not sure if this change is absolutely necessary.
b). Fixes a syntax error when DEBUG_GL_COMMANDS is NOT defined. Basically, this change was intended just to fix a missing semi-colon in the following block,

 #ifdef DEBUG_GL_COMMANDS
 #define GL_CMD(x) {x, debugGLCommand(#x, __LINE__); }
 #else
 #define GL_CMD(x) x
 #endif

To

 #ifdef DEBUG_GL_COMMANDS
 #define GL_CMD(x) {x, debugGLCommand(#x, __LINE__); }
 #else
 #define GL_CMD(x) x; // Note the ; here
 #endif

But, I feel convention "GL_CMD(cmd);" is better than "GL_CMD(cmd)". Hence changed the usage of macro a bit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.