[Webkit-unassigned] [Bug 74074] [Qt] Visualize mock points in the Qt MiniBrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74074





--- Comment #2 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-12-08 05:02:39 PST ---
(From update of attachment 118363)
View in context: https://bugs.webkit.org/attachment.cgi?id=118363&action=review

> Tools/ChangeLog:16
> +        * MiniBrowser/qt/qml/TouchMockPoint.qml: Copied from Tools/MiniBrowser/qt/BrowserWindow.h.

Pretty stupid comment :-) pls remove and add Added

> Tools/MiniBrowser/qt/BrowserWindow.cpp:88
> +    QHash<int, QQuickItem*>::iterator iter = m_touchMockPoints.find(id);

we normally use the name "it" in webkit

> Tools/MiniBrowser/qt/BrowserWindow.cpp:99
> +
> +    iter.value()->setX(position.x() / 2);
> +    iter.value()->setY(position.y() / 2);
> +    iter.value()->setOpacity(opacity);

why not (*it)->set...

> Tools/MiniBrowser/qt/MiniBrowserApplication.cpp:174
> +            // Get rid of touch-points that are no longer valid

+ . at the end :-)

> Tools/MiniBrowser/qt/qml/TouchMockPoint.qml:31
> +    visible: true

isn't that default?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.