[Webkit-unassigned] [Bug 73533] Upstream the Blackberry porting of multipart delegate

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73533





--- Comment #9 from Leo Yang <leo.yang at torchmobile.com.cn>  2011-12-07 22:49:46 PST ---
(From update of attachment 118318)
View in context: https://bugs.webkit.org/attachment.cgi?id=118318&action=review

Informal review.

> Source/WebCore/platform/network/blackberry/MultipartResponseDelegate.cpp:219
> +        size_t curParamStart = parameterStart + 1;

curParamStart --> currentParamterStart
And the corresponding usages should be updated.

> Source/WebCore/platform/network/blackberry/MultipartResponseDelegate.cpp:351
> +        // Eat leading \r\n

You are missing a '.' at the end.

> Source/WebCore/platform/network/blackberry/MultipartResponseDelegate.cpp:354
> +        int pos = pushOverLine(m_data, 0);
> +        if (pos)
> +            m_data = m_data.substr(pos);

pos --> position

> Source/WebCore/platform/network/blackberry/MultipartResponseDelegate.cpp:372
> +        int pos = pushOverLine(m_data, 0);
> +        if (pos)
> +            m_data = m_data.substr(pos);

pos --> position.

> Source/WebCore/platform/network/blackberry/MultipartResponseDelegate.cpp:415
> +        // Ok, back to parsing headers

You are missing a '.' at the end.

> Source/WebCore/platform/network/blackberry/MultipartResponseDelegate.cpp:469
> +            // A blank line, end of headers

You are missing a '.' at the end.

> Source/WebCore/platform/network/blackberry/MultipartResponseDelegate.cpp:481
> +    // Eat headers

Ditto.

> Source/WebCore/platform/network/blackberry/MultipartResponseDelegate.h:76
> +    // Checks to see if data[pos] character is a line break; handles crlf, lflf,
> +    // lf, or cr. Returns the number of characters to skip over (0, 1 or 2).
> +

What's this for?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.