[Webkit-unassigned] [Bug 73541] upstream 5 files into WebCore/platform/blackberry

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 7 14:52:09 PST 2011


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
 Attachment #117824|commit-queue?               |commit-queue-
               Flag|                            |

--- Comment #9 from Rob Buis <rwlbuis at gmail.com>  2011-12-07 14:52:09 PST ---
(From update of attachment 117824)
View in context: https://bugs.webkit.org/attachment.cgi?id=117824&action=review

Looking quite good, some small stuff left, so r- for now.

> Source/WebCore/platform/blackberry/PlatformScreenBlackBerry.cpp:44
> +FloatRect screenAvailableRect(Widget* widget)

widget not used, so can be removed.

> Source/WebCore/platform/blackberry/PlatformScreenBlackBerry.cpp:49
> +FloatRect screenRect(Widget* widget)


> Source/WebCore/platform/blackberry/SSLKeyGeneratorBlackBerry.cpp:27
> +

Extra empty line not needed.

> Source/WebCore/platform/blackberry/SSLKeyGeneratorBlackBerry.cpp:30
> +void getSupportedKeySizes(Vector<String>& sizes)

sizes not used, so can be removed.

> Source/WebCore/platform/blackberry/WidgetBlackBerry.cpp:27
> +#include "ScrollView.h"

Is ScrollView include needed?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list