[Webkit-unassigned] [Bug 73798] Upstream 6 files into WebCore/platform/blackberry

Wed Dec 7 14:36:42 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=73798

Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #117852|review?                     |review-
               Flag|                            |

--- Comment #5 from Rob Buis <rwlbuis at gmail.com>  2011-12-07 14:36:42 PST ---
(From update of attachment 117852)
View in context: https://bugs.webkit.org/attachment.cgi?id=117852&action=review

Looks good, but some stuff that can be improved, so r- for now.

> Source/WebCore/platform/blackberry/PlatformTouchEventBlackBerry.cpp:38
> +#if PLATFORM(BLACKBERRY) && OS(QNX)

I talked with Dan and this is not needed. OS(QNX) is not needed at all. PLATFORM(BLACKBERRY) is implied since we only compile this on for BlackBerry. So you can remove the test.

> Source/WebCore/platform/blackberry/SharedTimerBlackBerry.cpp:32
> +    static SharedTimerBlackBerry* inst();

I think instance is a better name.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.