[Webkit-unassigned] [Bug 73194] [BlackBerry] Add notification support for the BlackBerry port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73194


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #117136|review?                     |review-
               Flag|                            |




--- Comment #10 from Rob Buis <rwlbuis at gmail.com>  2011-12-07 14:22:06 PST ---
(From update of attachment 117136)
View in context: https://bugs.webkit.org/attachment.cgi?id=117136&action=review

Looks quite close to being finished, some nits, so r- for now :)

> Source/WebKit/blackberry/WebCoreSupport/NotificationPresenterImpl.cpp:52
> +bool NotificationPresenterImpl::show(Notification* n)

For consistency needs (Notification* notification), see notificationObjectDestroyed.

> Source/WebKit/blackberry/WebCoreSupport/NotificationPresenterImpl.cpp:77
> +void NotificationPresenterImpl::cancel(Notification* n)

Ditto.

> Source/WebKit/blackberry/WebCoreSupport/NotificationPresenterImpl.cpp:126
> +    // FIXME: Should store the permission information into file permenently instead of in m_allowedDomains.

Typo -> permanently

> Source/WebKit/blackberry/WebCoreSupport/NotificationPresenterImpl.h:56
> +    // Cancel all outstanding requests for the ScriptExecutionContext

misses '.' at the end.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.