[Webkit-unassigned] [Bug 73911] <li value="0"> behaves like <li> (the same for negative numbers)

Wed Dec 7 09:10:52 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=73911

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #118217|review?                     |review+
               Flag|                            |

--- Comment #6 from Darin Adler <darin at apple.com>  2011-12-07 09:10:52 PST ---
(From update of attachment 118217)
Patch seems OK. Three thoughts:

1) This logic should not be repeated twice. We should find a way to share the code between these two call sites.
2) There is no need for a special case for the null string in HTMLLIElement::attach.
3) Normally I would spell it "OK", not "Ok".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.