[Webkit-unassigned] [Bug 73616] Asynchronous path and synchronous path of SpellChecker should share the code to mark misspellings

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 7 03:30:47 PST 2011


MORITA Hajime <morrita at google.com> changed:

           What    |Removed                     |Added
 Attachment #118196|review?                     |review-
               Flag|                            |

--- Comment #3 from MORITA Hajime <morrita at google.com>  2011-12-07 03:30:47 PST ---
(From update of attachment 118196)
View in context: https://bugs.webkit.org/attachment.cgi?id=118196&action=review

Could you split the patch into some trivial part (like renaming, exporting an internal class, etc.) and possibly-observable change like make marking code shared?

> Source/WebCore/ChangeLog:6
> +        Need a short description and bug URL (OOPS!)

You don't need this.

> Source/WebCore/editing/SpellChecker.h:80
> +    class InternalSpellCheckRequest;

This doesn't need to be a nested class.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list