[Webkit-unassigned] [Bug 73309] [Qt] GC should be parallel on Qt platform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73309


Zoltan Herczeg <zherczeg at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #118189|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #6 from Zoltan Herczeg <zherczeg at webkit.org>  2011-12-07 02:27:34 PST ---
(From update of attachment 118189)
Nice speedup!

A couple of things:

View in context: https://bugs.webkit.org/attachment.cgi?id=118189&action=review

> Source/JavaScriptCore/runtime/Heuristics.cpp:-202
>  } } // namespace JSC::Heuristics
> -
> -

Please don't delete these lines.

> Source/JavaScriptCore/wtf/MainThread.h:54
> +void initializeGCThreads();

Plural? I thought there is only one thread.

> Source/JavaScriptCore/wtf/NumberOfCores.cpp:82
>  #endif
>  
>      }
> -
>      return s_numOfCores;
>  }
>  

No node /trunk/Source/JavaScriptCore/wtf/NumberOfCores.cpp at revision 102229

The system does not know this file...

> Source/JavaScriptCore/wtf/ParallelJobsGeneric.h:133
> +    static Vector< RefPtr<ThreadPrivate> >* s_threadPool;    

Do not add extra whitepsace at the end of a line.

> Source/JavaScriptCore/wtf/Platform.h:1120
> -#if !defined(ENABLE_PARALLEL_GC) && PLATFORM(MAC) && ENABLE(COMPARE_AND_SWAP)
> +#if !defined(ENABLE_PARALLEL_GC) && (PLATFORM(MAC)  || PLATFORM(QT)) && ENABLE(COMPARE_AND_SWAP)

Only one space between (PLATFORM(MAC) || PLATFORM(QT))

> Source/JavaScriptCore/wtf/mac/MainThreadMac.mm:164
>  }
>  #endif
> +*/

Why did you comment out these lines? Shouldn't you remove them?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.