[Webkit-unassigned] [Bug 73903] [V8] Multiple VMs: support <script type>with types other than JavaScript.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73903





--- Comment #2 from Eric Seidel <eric at webkit.org>  2011-12-06 12:22:00 PST ---
(From update of attachment 118018)
View in context: https://bugs.webkit.org/attachment.cgi?id=118018&action=review

> Source/WebCore/bindings/v8/ScriptController.h:74
> +class AbstractController : public RefCounted<AbstractController> {
> +public:
> +    virtual ~AbstractController() {}
> +
> +    virtual bool isScriptTypeSupported(const String& mimeType) = 0;
> +    virtual void evaluate(const ScriptSourceCode&) = 0;
> +    virtual void bindToWindowObject(Frame*, const String& key, NPObject*) = 0;
> +    virtual void clearWindowShell() = 0;
> +};
> +

This is a really horrible class name.  It's still a ScriptConroller... just of a diferent kind of script.

> Source/WebCore/bindings/v8/ScriptController.h:202
> +    AbstractController* controller(const String& name);

This would need to be conrollerForMimeType?

> Source/WebCore/bindings/v8/ScriptController.h:214
> +    typedef HashMap<String, RefPtr<AbstractController> > ControllerMap;
> +    ControllerMap m_controllers;
> +

Again, way too generic of names.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.