[Webkit-unassigned] [Bug 71968] Implement URL API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 6 10:33:27 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=71968


Erik Arvidsson <arv at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #118024|review?                     |review-
               Flag|                            |




--- Comment #39 from Erik Arvidsson <arv at chromium.org>  2011-12-06 10:33:27 PST ---
(From update of attachment 118024)
View in context: https://bugs.webkit.org/attachment.cgi?id=118024&action=review

> Source/WebCore/html/DOMURL.idl:59
>  #if defined(ENABLE_MEDIA_STREAM) && ENABLE_MEDIA_STREAM
> -        [ConvertNullStringTo=Undefined] DOMString createObjectURL(in MediaStream stream);
> +        [Conditional=BLOB] static DOMString createObjectURL(in MediaStream stream);
>  #endif
> -        [ConvertNullStringTo=Undefined] DOMString createObjectURL(in Blob blob);
> -        void revokeObjectURL(in DOMString url);
> +        [Conditional=BLOB] static DOMString createObjectURL(in Blob blob);
> +        static [Conditional=BLOB] void revokeObjectURL(in DOMString url);

These needs to be 

static [Conditional=BLOB] type name(params);

However, beware that you will need to keep the #if here since overloaded methods cannot have different Conditional. Maybe a comment is due?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list