[Webkit-unassigned] [Bug 73869] BlackBerry PlayBook doesn't sniff mime types

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73869


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #118046|review?                     |review-
               Flag|                            |




--- Comment #2 from Rob Buis <rwlbuis at gmail.com>  2011-12-06 08:05:38 PST ---
(From update of attachment 118046)
View in context: https://bugs.webkit.org/attachment.cgi?id=118046&action=review

This really needs a ChangeLog! Looks quite good otherwise.

> Source/WebCore/platform/network/MIMESniffing.cpp:28
> +using std::strlen;

This should not be needed. Also it may be better to do this in a seperate bug.

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:364
> +            if (pos != -1) {

pos variable can be introduced in the if

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:374
> +            const char* type = sniffer.sniff(buf, len);

Can be included in if.

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:376
> +            	m_sniffedMimeType = WTF::String(type);

Wrong indentation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.