[Webkit-unassigned] [Bug 73451] [NRWT] It crashes intermittently when there are WebProcess crashes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73451





--- Comment #6 from Csaba Osztrogonac <ossy at webkit.org>  2011-12-06 05:24:37 PST ---
(In reply to comment #4)
> Looks like a design error.
> 
> _reset() can clear self._proc.  _check_for_crash grabs at self._proc w/o checking if it's None or if self.crashed in many places.  We just need to re-work that to never be the case.

Do you mean we should use self.poll() instead of self._proc.poll() everywhere?

def poll(self):
    """Check to see if the underlying process is running; returns None
    if it still is (wrapper around subprocess.poll)."""
    if self._proc:
        return self._proc.poll()
    return None

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.