[Webkit-unassigned] [Bug 73511] Internals should have a method to return the max sequence number of spellcheck request.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Dec 6 03:58:09 PST 2011
https://bugs.webkit.org/show_bug.cgi?id=73511
MORITA Hajime <morrita at google.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #118005|review? |review-
Flag| |
--- Comment #8 from MORITA Hajime <morrita at google.com> 2011-12-06 03:58:08 PST ---
(From update of attachment 118005)
View in context: https://bugs.webkit.org/attachment.cgi?id=118005&action=review
Basically looks nice. I pointed some nits.
> Source/WebCore/testing/Internals.cpp:624
> + if (!document || !document->frame() || !document->frame()->editor() || !document->frame()->editor()->spellChecker()) {
Could you add a getter for spellchecker like Internals::spellchecker()?
> LayoutTests/ChangeLog:8
> + Tests to check internals.lastSpellCheckRequestSequence and internals.lastSpellCheckProcessedSequence.
"Added tests"?
> LayoutTests/ChangeLog:12
> +
I guess we need to skip on some ports. You will know which ports do ;-)
> LayoutTests/editing/spelling/spellcheck-sequencenum.html:111
> + testPassed("SpellCheck sequence seems work correctly.");
"seems working"?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list