[Webkit-unassigned] [Bug 73817] [TexMap][QT] TexMap does not draw the border of media and webgl elements.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 5 18:24:53 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=73817





--- Comment #13 from Noam Rosenthal <noam.rosenthal at nokia.com>  2011-12-05 18:24:54 PST ---
(In reply to comment #11)
> (From update of attachment 117964 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=117964&action=review
> 
> You can probably get the same result without redundant updates by getting rid of some code :)
> 
> > Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:73
> > +        m_pendingContent.needsDisplay = true;
> 
> You can probably remove these two lines; otherwise you're causing unnecessary updates.
> 
> > Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:301
> > -    if (m_currentContent.contentType == MediaContentType)
> > +    if (m_currentContent.contentType == MediaContentType && !m_currentContent.needsDisplay)
> >          return;
> 
> The code would probably work just the same if you remove these lines from the code altogether.

Correction: You do need the first one, because setContentsNeedsDisplay is also called for images. So, a blend between the two last patches should work (include the stuff around line 73, remove the stuff around 301).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list