[Webkit-unassigned] [Bug 73817] [TexMap][QT] TexMap does not draw the border of media and webgl elements.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73817


Noam Rosenthal <noam.rosenthal at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #117958|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #8 from Noam Rosenthal <noam.rosenthal at nokia.com>  2011-12-05 17:22:24 PST ---
(From update of attachment 117958)
View in context: https://bugs.webkit.org/attachment.cgi?id=117958&action=review

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:307
> +    if (m_currentContent.contentType == MediaContentType && !m_currentContent.needsDisplay) {
> +        m_currentContent.needsDisplayContents = false;
>          return;
> +    }
> +    if (m_currentContent.contentType != MediaContentType) {
> +        m_currentContent.needsDisplay = m_currentContent.needsDisplayContents;
> +        m_currentContent.needsDisplayContents = false;
> +    }

This is very hard to read. I think you want a temporary variable here instead of modifying m_currentContent.needsDisplay.

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.h:123
> +        bool needsDisplayContents;

contentsNeedsDisplay

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.