[Webkit-unassigned] [Bug 59652] turn on move caret by word visually for windows platform.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59652





--- Comment #25 from Xiaomei Ji <xji at chromium.org>  2011-12-05 16:54:26 PST ---
Created an attachment (id=117957)
 --> (https://bugs.webkit.org/attachment.cgi?id=117957&action=review)
patch w/ layout test

Updated the patch to fix qt-ews, cr-ews error.

(In reply to comment #22)
> (From update of attachment 117723 [details])
> Doesn't this mean some other editing tests that use modify("move", *, "word") will start failing?

we do not seem to have such  tests before.



(In reply to comment #24)
> (From update of attachment 117723 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=117723&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        Turn on move caret by word visually for windows platform.
> > +        https://bugs.webkit.org/show_bug.cgi?id=59652
> > +
> > +        Reviewed by NOBODY (OOPS!).
> > +
> > +        Implements platform differences using EditingBehavior.
> > +
> > +        Test: editing/selection/move-left-right-by-word-mac.html
> 
> This is a bit too terse. It would be good to explain what the behavior without this patch is, what the behavior with this patch is, and which behavior (if either) matches other browsers.

Added comments per suggestion.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.