[Webkit-unassigned] [Bug 73632] Upstream 7 files into WebCore/platform/blackberry

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73632


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #117854|review?                     |review-
               Flag|                            |




--- Comment #10 from Rob Buis <rwlbuis at gmail.com>  2011-12-05 09:11:36 PST ---
(From update of attachment 117854)
View in context: https://bugs.webkit.org/attachment.cgi?id=117854&action=review

Looks good, nearly there, could be improved a bit, so r-.

> Source/WebCore/platform/blackberry/PopupMenuBlackBerry.h:23
> +#include "PopupMenuClient.h"

I think a forward reference for PopupMenuClient should do.

> Source/WebCore/platform/blackberry/ScrollbarThemeBlackBerry.cpp:29
> +    static ScrollbarTheme theme;

Can DEFINE_STATIC_LOCAL be used here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.