[Webkit-unassigned] [Bug 73628] Refactoring: Editor::markAllMisspellingsAndBadGrammarInRanges should be refactored.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 5 03:24:16 PST 2011


MORITA Hajime <morrita at google.com> changed:

           What    |Removed                     |Added
 Attachment #117855|review?                     |review-
               Flag|                            |

--- Comment #4 from MORITA Hajime <morrita at google.com>  2011-12-05 03:24:15 PST ---
(From update of attachment 117855)
View in context: https://bugs.webkit.org/attachment.cgi?id=117855&action=review

Basically looks nice. There are only a few nits.

> Source/WebCore/editing/Editor.cpp:2045
> +    ExceptionCode ec = 0;

It's good opportunity to eliminate this. You can use ASSERT_NO_EXCEPTION.

> Source/WebCore/editing/Editor.h:39
> +#include "TextCheckingHelper.h"

I really want hide this in .cpp file.

> Source/WebCore/editing/Editor.h:408
> +    void markAndReplaceFor(TextCheckingTypeMask, const Vector<TextCheckingResult>&, TextCheckingParagraph spellingParagraph, TextCheckingParagraph grammarParagraph);

Is it possible to pass TextCheckingParagraph as a reference or a pointer?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list