[Webkit-unassigned] [Bug 73632] Upstream 7 files into WebCore/platform/blackberry

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 5 00:18:38 PST 2011


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #117822|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |

--- Comment #7 from Daniel Bates <dbates at webkit.org>  2011-12-05 00:18:37 PST ---
(From update of attachment 117822)
View in context: https://bugs.webkit.org/attachment.cgi?id=117822&action=review

> Source/WebCore/platform/blackberry/PopupMenuBlackBerry.cpp:33
> +void PopupMenuBlackBerry::show(const IntRect& r, FrameView* v, int index)

All of these parameters are unused. Either we need to use UNUSED_PARAM() or we need to omit them from the signature here or this may cause unused variable warnings depending on the compiler warning level.

> Source/WebCore/platform/blackberry/ScrollViewBlackBerry.cpp:22
> +namespace WebCore {

Why do we need to commit this almost empty file?

> Source/WebCore/platform/blackberry/ScrollbarBlackBerry.cpp:22
> +namespace WebCore {


Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list