[Webkit-unassigned] [Bug 73798] Upstream 6 files into WebCore/platform/blackberry
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 5 00:06:24 PST 2011
https://bugs.webkit.org/show_bug.cgi?id=73798
Daniel Bates <dbates at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #117844|review? |review-
Flag| |
--- Comment #2 from Daniel Bates <dbates at webkit.org> 2011-12-05 00:06:24 PST ---
(From update of attachment 117844)
View in context: https://bugs.webkit.org/attachment.cgi?id=117844&action=review
> Source/WebCore/platform/blackberry/FileSystemBlackBerry.cpp:25
> +#include "Vector.h"
This should be:
#include <wtf/Vector.h>
> Source/WebCore/platform/blackberry/FileSystemBlackBerry.cpp:102
> + return "";
Nit: return String()
(call the default constructor instead of C-string variant.
> Source/WebCore/platform/blackberry/PlatformTouchEventBlackBerry.cpp:2
> + * This file is part of the WebKit project.
This remark is obvious given you're proposing to land this file in the WebKit.org tree.
> Source/WebCore/platform/blackberry/PlatformTouchEventBlackBerry.cpp:60
> + for (unsigned int i = 0; i < event->m_points.size(); ++i)
unsigned int => unsigned
I take it the compiler is smart enough to either cache event->m_points or event->m_points.size(). Otherwise, I suggest caching this value in a local variable.
> Source/WebCore/platform/blackberry/SharedBufferBlackBerry.cpp:24
> +#include "PassRefPtr.h"
This should be:
#include <wtf/PassRefPtr.h>
> Source/WebCore/platform/blackberry/SharedBufferBlackBerry.cpp:28
> +WTF::PassRefPtr<SharedBuffer> SharedBuffer::createWithContentsOfFile(String const&)
Do we need the WTF:: prefix here?
> Source/WebCore/platform/blackberry/SystemTimeBlackBerry.cpp:30
> + return 0.0f;
This should be:
return 0;
Per the style rules and by implicit conversion of the return value.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list