[Webkit-unassigned] [Bug 73789] Need SSE optimization for SincResampler::Process()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 4 23:35:20 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=73789





--- Comment #8 from xingnan.wang at intel.com  2011-12-04 23:35:20 PST ---
(In reply to comment #5)
> (From update of attachment 117838 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=117838&action=review
> 
> > Source/WebCore/platform/audio/SincResampler.cpp:287
> > +                    pInput = reinterpret_cast<__m128*>(const_cast<float*>(inputP));
> > +                    pK1 = reinterpret_cast<__m128*>(const_cast<float*>(k1));
> > +                    pK2 = reinterpret_cast<__m128*>(const_cast<float*>(k2));
> 
> Personally I prefer to have _mm_load_ps explicitly but that is a question of style I guess...

I tried to use _mm_load_ps instead of _cast way and got some regression, from about 45% to 38%. I think the additional ops of function call resulted it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list