[Webkit-unassigned] [Bug 73750] [GTK] Move emissions of AtkDocument signals down to WebCore

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 4 21:05:45 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=73750





--- Comment #5 from chris fleizach <cfleizach at apple.com>  2011-12-04 21:05:45 PST ---
(From update of attachment 117768)
View in context: https://bugs.webkit.org/attachment.cgi?id=117768&action=review

> Source/WebCore/accessibility/AXObjectCache.h:153
> +        AXLoadingReload,

this should be Reloaded

> Source/WebCore/accessibility/AXObjectCache.h:158
> +    void loadingEventNotification(Frame*, AXLoadingEvent);

i would name this frameLoadingEventNotification

> Source/WebCore/accessibility/gtk/AXObjectCacheAtk.cpp:195
> +    // Sanity check

comment is unnecessary

> Source/WebCore/loader/FrameLoader.cpp:1123
> +            : AXObjectCache::AXLoadingStarted;

probably not necessary to separate onto three lines

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list