[Webkit-unassigned] [Bug 73534] upstream BlackBerry porting of MIMETypeRegistry/KeyboardEvent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73534





--- Comment #5 from Antonio Gomes <tonikitoo at webkit.org>  2011-12-04 20:38:26 PST ---
(From update of attachment 117827)
View in context: https://bugs.webkit.org/attachment.cgi?id=117827&action=review

> Source/WebCore/ChangeLog:18
> +        Initial upstream, no new tests.
> +
> +
> +        * platform/blackberry/MIMETypeRegistryBlackBerry.cpp: Added.

extra new line.

> Source/WebCore/platform/blackberry/MIMETypeRegistryBlackBerry.cpp:135
> +bool MIMETypeRegistry::isApplicationPluginMIMEType(const String& mimeType)

Either do

bool MIMETypeRegistry::isApplicationPluginMIMEType(const String& /*mimeType*/)

or add a UNUSED_PARAM(mimeType) line.

> Source/WebCore/platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:2
> + * Copyright (C) 2009, 2010 Research In Motion Limited. All rights reserved.

2011?

> Source/WebCore/platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:485
> +void PlatformKeyboardEvent::getCurrentModifierState(bool& shiftKey, bool& ctrlKey, bool& altKey, bool& metaKey)

UNNEEDED_PARAM(xxx)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.