[Webkit-unassigned] [Bug 73683] New: KeyframeValueList::operator= is neither safe to use nor prohibited

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 2 12:30:03 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=73683

           Summary: KeyframeValueList::operator= is neither safe to use
                    nor prohibited
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Trivial
          Priority: P5
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: yong.li.webkit at gmail.com


When looking at GraphicLayer.h, I noticed that KeyframeValueList is copyable now, and it has a safe copy constructor. However, its default operator= is still unsafe.

We should either implement an operator= or simply disable it.

Not a big deal. But it would be nice we include something like this in webkit coding guidelines: when implement a copy constructor, please also implement operator=, and vice versa.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list