[Webkit-unassigned] [Bug 73662] [GTK] Add downloads support to MiniBrowser

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 2 08:44:58 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=73662


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2011-12-02 08:44:58 PST ---
Attachment 117633 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/MiniBrowser/gtk/..." exit_code: 1

Tools/MiniBrowser/gtk/BrowserDownloadsBar.h:47:  The parameter name "downloadsBar" adds no information, so it should be removed.  [readability/parameter_name] [5]
Tools/MiniBrowser/gtk/BrowserDownloadsBar.h:48:  The parameter name "download" adds no information, so it should be removed.  [readability/parameter_name] [5]
Tools/MiniBrowser/gtk/BrowserDownloadsBar.h:48:  Extra space between WebKitDownload and *download  [whitespace/declaration] [3]
Tools/MiniBrowser/gtk/BrowserDownloadsBar.c:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list