[Webkit-unassigned] [Bug 70304] width/height attributes of input element should be supported when the type of the input element is image.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 1 22:51:29 PST 2011
https://bugs.webkit.org/show_bug.cgi?id=70304
Kent Tamura <tkent at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #117571|review? |review-
Flag| |
--- Comment #38 from Kent Tamura <tkent at chromium.org> 2011-12-01 22:51:27 PST ---
(From update of attachment 117571)
View in context: https://bugs.webkit.org/attachment.cgi?id=117571&action=review
> LayoutTests/fast/forms/input-width-height-attributes.html:54
> +var div1 = document.getElementById("div1");
The variable div1 - div8 are not needed.
> LayoutTests/fast/forms/input-width-height-attributes.html:86
> +text1.width = 100;
> +text1.height = 50;
> +debug('Test case #5 : Text, Setting by JavaScript API as \"100\", \"50\"');
> +shouldBe('text1.width,text1.height', '0,0');
> +
After this, we had better test:
- text1 has width= and height= HTML attributes.
- Changing the type to image, width/height values are not changed.
> Source/WebCore/html/InputType.cpp:753
> +void InputType::setHeight(unsigned height)
> +{
> + element()->setAttribute(heightAttr, String::number(height));
> +}
> +
> +void InputType::setWidth(unsigned width)
> +{
> + element()->setAttribute(widthAttr, String::number(width));
> +}
> +
No other *InputType overrides setHeight() and setWidth(). We can remove them and move the code to HTMLInputElement::setHeight()/setWidth().
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list