[Webkit-unassigned] [Bug 72956] [chromium] Drop root layer tiles on platforms that cache the front buffer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72956





--- Comment #12 from Nat Duca <nduca at chromium.org>  2011-12-01 21:32:42 PST ---
This patch stashes a bool discardAllTextures on the CCSettings struct, which is a misuse of the CCSettings struct, or i'm misunderstanding its purpose.

Afaict, the discardAllTextures really is just a cached value of LayerRendererCapabilities::usingFrontBufferCached.

CCSettings is a struct that exposes "compositor features" to embedders of the compositor API. This is not a public feature.

LayerRendererCapabilities is available on both the impl thread an the main thread. From CCLayerTreeHost, you can efficiently obtain the capabilities with m_proxy->layerRendererCapabilities().

Also, the variable names here are massively inconsistent. I would love the capabilities bit to be contextHasCachedFrontBuffer or contextSupportsFrontBufferCached.

Sorry I didn't catch this in the previous codereview. /me was out sick.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.