[Webkit-unassigned] [Bug 73235] [Chromium] Support adding/removing page overlay to WebView

Thu Dec 1 21:26:50 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=73235

--- Comment #39 from James Robinson <jamesr at chromium.org>  2011-12-01 21:26:50 PST ---
(In reply to comment #38)

> 
> directRect is useful in composting code path. e.g. WebViewImpl::composite is called when devtools changes highlight and right now, we call PageOverlay::update on all overlays. And if we don't have dirtyRect, dimming overlay will setNeedsDispaly on its layer and paints the dimming again even though nothing changed. With dirtyRect, we could save this unnecessary paint.

Hmm...but whenever the devtools overlay changes its dirtyRect is the entire viewport, so I'm not sure what we are saving.

It is possible to optimize this case. However, it doesn't seem that the code today is getting any benefit, and if we do want to get this benefit we need to do it in a different way. I'd rather not worry about it. This is not a performance-critical codepath.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.