[Webkit-unassigned] [Bug 73544] [EFL] Add Web Notification feature for Efl port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73544





--- Comment #2 from Ryuan Choi <ryuan.choi at samsung.com>  2011-12-01 17:41:09 PST ---
(From update of attachment 117390)
View in context: https://bugs.webkit.org/attachment.cgi?id=117390&action=review

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:81
> +void NotificationPresenterClientEfl::makePermissionCache(char** domains, int size)

Can we pass Vector<String> instead of domains and size ?

> Source/WebKit/efl/ewk/ewk_private.h:238
> +void ewk_view_notification_request_permission(Evas_Object* ewkView, const char* domain);

permission_request?

> Source/WebKit/efl/ewk/ewk_view.h:2329
> +/**
> + * Make a cacheList for permitted domains
> + * This function is called when initializing a browser application.
> + *
> + * @param ewkView view to receive message from browser
> + * @param Ewk_Notification notification pointer for receive display event
> + *
> + */
> +EAPI void ewk_view_notification_add_permitted_domains(const Evas_Object* ewkView, char** domains, int size);

It doesn't looks EFL style.
we decide not to change o to ewkView in public header.

And IMO, We'd better to use Eina_List instead of char** and size.

And also, please check doxygen.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.