[Webkit-unassigned] [Bug 73603] nrwt shouldn't blow up when there are errors in test_expectations.txt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 1 16:54:04 PST 2011


Dirk Pranke <dpranke at chromium.org> changed:

           What    |Removed                     |Added
                 CC|                            |ojan at chromium.org,
                   |                            |tony at chromium.org

--- Comment #1 from Dirk Pranke <dpranke at chromium.org>  2011-12-01 16:54:03 PST ---
NRWT fails by design; having errors like duplicate expectations is bad and shouldn't be ignored; in other words, if there is an error in the expectations file, it should fail the build step. But I don't think you're suggesting the errors should be ignored completely (i.e., what would happen if we just turned them into warnings).

I think one problem now is that when this does fail, the reason for the failure isn't obvious on the waterfall ... you get a ??? rather than "bad expectations" or something. It may partially because (IIRC) duplicate expectations actually cause a stack trace rather than an orderly exit.

I think one could argue that a bad expectation, if it was obvious enough, should be sufficient, because it would be quickly corrected.

However, I could also be convinced that NRWT should run what it can unambiguously run and come up with some sort of meaningful failure interpretation.

Another possibility would be to add a new --lint-test-files builds step that turned red separately from the actual test run. Then the test run would be free to treat the parsing failures as warnings and proceed on.

CC'ing Tony and Ojan on this since I believe they've held opinions on this in the past.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list