[Webkit-unassigned] [Bug 64290] The layout of RenderBox should be calculated using fixedLayoutSize instead of viewport when the fixedLayoutSize is set.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 1 13:41:50 PST 2011


--- Comment #12 from Fady Samuel <fsamuel at chromium.org>  2011-12-01 13:41:50 PST ---
(From update of attachment 100314)
View in context: https://bugs.webkit.org/attachment.cgi?id=100314&action=review

>>> Source/WebCore/ChangeLog:18
>>> +        No tests because this change affects only when fixedLayoutSize is set. Since our dumpRenderTree doesn't set it, we can't test this.
>> DumpRenderTree has a layoutConstroller.overridePreference() which can be used to toggle a setting for a single test.  Seems if your DRT supports that (which ideally it should), it would be easy to write a test for this.
> No. layoutController.overridePreference() is not helpful because it toggles only settings of WebSettings.
> To turn on the fixedLayoutSize feature, to test this patch, FrameView::setUseFixedLayout(true) have to be called.
> I think there is no easy way to turn on this feature for a single test.

It just so happens that I have two layout tests that address precisely this problem and I added fixedLayout to the chromium DRT (I'm not sure if it's in other DRTs at the moment). I will move this to window.internals, I guess.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list