[Webkit-unassigned] [Bug 73345] [chromium] Split scrollRootLayer() into scroll{Begin, By, End}()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 1 11:23:03 PST 2011


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
 Attachment #117421|review?                     |review+, commit-queue-
               Flag|                            |

--- Comment #10 from James Robinson <jamesr at chromium.org>  2011-12-01 11:23:04 PST ---
(From update of attachment 117421)
View in context: https://bugs.webkit.org/attachment.cgi?id=117421&action=review

This looks great. R=me but I can't set cq+ since this patch has merge conflicts.

> Source/WebCore/platform/graphics/chromium/cc/CCInputHandler.h:63
> +    // Stop scrolling the layer selected with scrollBegin().

It appears from the logic that you only need to call this when scrollBegin() returns ScrollStarted, which makes sense to me. Could you document this requirement in the header?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list