[Webkit-unassigned] [Bug 67864] [Qt] Win32 builds with threads turned off

Thu Dec 1 07:53:49 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=67864

Paul <harris.pc at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |harris.pc at gmail.com

--- Comment #23 from Paul <harris.pc at gmail.com>  2011-12-01 07:53:49 PST ---
I am using QT 4.7.4 with the included JavascriptCore.
I'm compiling for Win32 with MSVC 2008.  Running on Win7-64.

I'm using QScriptEngine (and therefore, JavascriptCore) in multiple threads, and while that seems to work fine (even before this patch), every time the app closed, it would crash on destruction.

The attached patch did not resolve this issue, so I investigated further.

This patch does not completely enable pthreads properly for me, so you end up with pthreads partially enabled, but JSC will still continue to use QMutex and other QT-related threading classes.

I fixed this problem, see attached patch.

I am aware that the development has moved on somewhat since this bug was closed, eg https://bugs.webkit.org/show_bug.cgi?id=72155

But I am not sure if anyone is seeing the same problems I am on Windows.  I expect most developers are on Macs/Linux (where I didn't have any issues).

I have attached a patch for your consideration.  It works against QT 4.7.4 so it will need adjustments to apply to the trunk.

Can we reopen this bug?

Thanks,
Paul

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.