[Webkit-unassigned] [Bug 72939] Asynchronous SpellChecker should consider multiple requests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72939


MORITA Hajime <morrita at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #117377|review?                     |review-
               Flag|                            |




--- Comment #6 from MORITA Hajime <morrita at google.com>  2011-12-01 01:52:17 PST ---
(From update of attachment 117377)
View in context: https://bugs.webkit.org/attachment.cgi?id=117377&action=review

> Source/WebCore/editing/SpellChecker.cpp:134
>  {

It looks we now can merge doRequestCheckingFor and requestCheckingFor().

> Source/WebCore/editing/SpellChecker.cpp:162
> +        if (request->rootEditableElement() != (*it)->rootEditableElement())

Could you store |request->rootEditableElement()| to a local var to save extra computation?

> Source/WebCore/editing/SpellChecker.cpp:165
> +        fprintf(stderr, "REMOVED!\n");

Please remove this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.