[Webkit-unassigned] [Bug 66336] New: ResourceRequest::doUpdatePlatformRequest() should clear http method

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 16 15:04:56 PDT 2011


           Summary: ResourceRequest::doUpdatePlatformRequest() should
                    clear http method
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Platform
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: psolanki at apple.com
                CC: ap at webkit.org

In ResourceRequestMac.mm, ResourceRequest::doUpdateResourceRequest() does

    if (NSString* method = [m_nsRequest.get() HTTPMethod])
        m_httpMethod = method;

This means that we don't clear out the m_httpMethod field if (e.g.) the NSURLRequest was nil. This can cause 2 ResourceRequests to be treated as different when they should be equal e.g. if the 2 ResourceRequests were created with different ctors. We have 2 different ResourceRequestBase actor - one sets the httpMethod to "GET" by default, the other doesn't do anything.

By contrast on the CFNetwork side, we always clear out all the fields.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list