[Webkit-unassigned] [Bug 67354] ValueProfile does not make it safe to introspect cell values after garbage collection
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 31 22:31:32 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=67354
--- Comment #7 from Filip Pizlo <fpizlo at apple.com> 2011-08-31 22:31:32 PST ---
This patch is performance-neutral. Only differences are ~0.1% and not statistically significant.
Benchmark report for SunSpider, V8, and Kraken.
VMs tested:
"TipOfTree" at /Volumes/Data/fromMiniMe/quinary/OpenSource/WebKitBuild/Release/jsc
"ValueProfileOff" at /Volumes/Data/fromMiniMe/septenary/OpenSource/WebKitBuild/Release/jsc
Collected 12 samples per benchmark/VM, with 4 VM invocations per benchmark. Used 1 benchmark iteration per VM
invocation for warm-up. Used the jsc-specific preciseTime() function to get microsecond-level timing. Reporting
benchmark execution times with 95% confidence intervals in milliseconds.
TipOfTree ValueProfileOff
SunSpider:
3d-cube 8.2470+-0.0678 ? 8.2512+-0.0164 ?
3d-morph 8.1477+-0.0334 8.1383+-0.0191
3d-raytrace 8.2481+-0.0654 ? 8.3196+-0.0619 ?
access-binary-trees 2.5407+-0.0381 ? 2.5602+-0.0468 ?
access-fannkuch 12.9529+-0.0845 12.9174+-0.0933
access-nbody 4.9614+-0.0487 4.9296+-0.0202
access-nsieve 3.0567+-0.0331 ? 3.0604+-0.0294 ?
bitops-3bit-bits-in-byte 1.8573+-0.0223 1.8571+-0.0231
bitops-bits-in-byte 5.6315+-0.1239 5.6254+-0.1335
bitops-bitwise-and 4.0975+-0.0087 4.0974+-0.0040
bitops-nsieve-bits 5.6903+-0.0320 ? 5.7280+-0.0336 ?
controlflow-recursive 2.2887+-0.0390 ? 2.2975+-0.0341 ?
crypto-aes 6.8440+-0.0369 ? 6.8944+-0.0393 ?
crypto-md5 3.0490+-0.0421 3.0027+-0.0277 might be 1.0154x faster
crypto-sha1 2.4497+-0.0374 ? 2.4579+-0.0359 ?
date-format-tofte 10.8528+-0.0671 10.8410+-0.0551
date-format-xparb 9.5181+-0.1963 ? 9.5994+-0.1459 ?
math-cordic 7.1568+-0.0921 ? 7.1719+-0.1217 ?
math-partial-sums 10.6718+-0.0497 ? 10.6829+-0.0345 ?
math-spectral-norm 2.7385+-0.0336 2.7294+-0.0277
regexp-dna 12.0845+-0.1535 12.0535+-0.1141
string-base64 6.5590+-0.1419 6.4790+-0.0848 might be 1.0123x faster
string-fasta 8.2849+-0.0352 ? 8.3050+-0.0290 ?
string-tagcloud 15.0656+-0.0444 14.9926+-0.0728
string-unpack-code 20.8166+-0.1082 20.7653+-0.0622
string-validate-input 7.3637+-0.3009 ? 7.6644+-0.2635 ? might be 1.0408x slower
<arithmetic> 7.3529+-0.0327 ? 7.3624+-0.0254 ?
<geometric> 6.0956+-0.0316 ? 6.1052+-0.0280 ?
<harmonic> 4.9775+-0.0342 ? 4.9834+-0.0324 ?
TipOfTree ValueProfileOff
V8:
crypto 102.7447+-0.2485 ? 103.1249+-0.2542 ?
deltablue 298.6366+-3.7481 ? 299.4765+-2.1650 ?
earley-boyer 123.2329+-0.4334 122.7717+-0.3203
raytrace 87.9043+-0.9485 87.6650+-0.1515
regexp 130.8935+-0.4964 ! 131.9634+-0.1790 ! definitely 1.0082x slower
richards 302.3704+-1.4350 ? 302.8294+-1.5887 ?
splay 155.8481+-1.6318 ? 156.0731+-0.9100 ?
<arithmetic> 171.6615+-0.4166 ? 171.9863+-0.3329 ?
<geometric> 153.9464+-0.1610 ? 154.1990+-0.1916 ?
<harmonic> 140.1632+-0.2503 ? 140.3450+-0.1274 ?
TipOfTree ValueProfileOff
Kraken:
ai-astar 1668.8957+-15.1645 1658.5114+-18.9078
audio-beat-detection 542.8552+-3.1601 540.6212+-3.8099
audio-dft 454.6839+-2.3303 ? 454.8397+-2.0129 ?
audio-fft 420.1154+-0.7348 ! 423.3887+-1.6151 ! definitely 1.0078x slower
audio-oscillator 403.3020+-0.8085 ? 404.7480+-0.9289 ?
imaging-darkroom 600.3491+-16.2923 ? 613.3811+-10.6584 ? might be 1.0217x slower
imaging-desaturate 636.5449+-17.4696 636.1784+-17.4582
imaging-gaussian-blur 1859.3143+-3.9366 1855.5966+-4.3500
json-parse-financial 61.4857+-0.2132 ! 63.2649+-0.1963 ! definitely 1.0289x slower
json-stringify-tinderbox 76.2311+-0.4255 75.8158+-0.2337
stanford-crypto-aes 165.7540+-0.4441 ? 166.3629+-0.5324 ?
stanford-crypto-ccm 131.5271+-0.6480 ? 132.6696+-0.9418 ?
stanford-crypto-pbkdf2 374.2624+-1.6078 ? 374.7365+-1.2595 ?
stanford-crypto-sha256-iterative 144.7434+-0.6826 144.1186+-0.2453
<arithmetic> 538.5760+-1.2589 ? 538.8738+-2.0228 ?
<geometric> 339.8348+-0.8563 ? 341.1243+-1.0454 ?
<harmonic> 212.5037+-0.4490 ! 214.1243+-0.4311 ! definitely 1.0076x slower
TipOfTree ValueProfileOff
All benchmarks:
<arithmetic> 190.0611+-0.3985 ? 190.2034+-0.5963 ?
<geometric> 32.6614+-0.1152 ? 32.7347+-0.1047 ?
<harmonic> 8.8026+-0.0593 ? 8.8137+-0.0562 ?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list