[Webkit-unassigned] [Bug 67357] New: TestWebKitAPI builder passes no -DNDEBUG to compiler in release mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67357

           Summary: TestWebKitAPI builder passes no -DNDEBUG to compiler
                    in release mode
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Macintosh
        OS/Version: Unspecified
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: wangxianzhu at chromium.org
                CC: sam at webkit.org, aroben at apple.com


Created an attachment (id=105894)
 --> (https://bugs.webkit.org/attachment.cgi?id=105894&action=review)
The patch for testing (not for review and commit)

TestWebKitAPI builder passes no -DNDEBUG to compiler in release mode, causes some header files to be mistakenly compiled and the TestWebKitAPI executable file isn't binary compatible with the shared libraries.

For example, RefCounted.h without -DNDEBUG will have some extra fields and assertions that are for debug mode only compiled in the executable.

To reproduce the problem:
1. patch the attached file;
2. build-api-tests [--release]
3. run-api-tests [--release]

ASSERTION FAILED: !m_deletionHasBegun
/Users/wangxianzhu/webkit/WebKitBuild/Release/JavaScriptCore.framework/PrivateHeaders/RefCounted.h(123) : bool WTF::RefCountedBase::derefBase()
1   WTF::RefCounted<WTF::CStringBuffer>::deref()
2   TestWebKitAPI::WTF_CrashInRelease_Test::TestBody()
3   testing::Test::Run()
4   testing::internal::TestInfoImpl::Run()
5   testing::TestCase::Run()
6   testing::internal::UnitTestImpl::RunAllTests()
7   TestWebKitAPI::TestsController::run(int, char**)
8   main
9   start
10  0x2

Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_INVALID_ADDRESS at address: 0x00000000bbadbeef
0x0000000100013bad in WTF::RefCountedBase::derefBase (this=0x103c013c0) at RefCounted.h:123
123            ASSERT(!m_deletionHasBegun);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.